ESLint Config Migration: Add test-specific ruleset #1044
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a PR that should be merged into #1024 and incrementally addresses #842.
This PR adds test-code-specific rules:
prefer-arrow-callback rule
- but only for test files (i.e.**/*.spec.ts
). The use offunction
over arrow syntax actually came up when writing tests in one time in Mocha (see Add tests for SocketModeReceiver (#750) #1012 (review)). As such, we shouldn't have the linter recommend to use only arrow functions in test files, as that may lead to the same situation as in Add tests for SocketModeReceiver (#750) #1012.consistent-type-assertions
rule), to allow for theconst x = { ... } as T
over theconst x: T = { ... }
syntax. The latter requires all properties of a type to be declared, whereas the former requires only the required properties to be defined. I believe theas T
syntax is handy to have in test code.symbol-descriptor
rule and allows for creatingSymbol
objects without a descriptor.Impact
Before
After
Requirements (place an
x
in each[ ]
)