Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #422 invalid fields in MultiUsersSelectAction #423

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented Mar 8, 2020

Summary

This pull request fixes #422 which is my bad in #344. This is a blocker for TypeScript users and is causing bad developer experiences for Visual Studio Code users.

Requirements (place an x in each [ ])

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific labels Mar 8, 2020
@seratch seratch self-assigned this Mar 8, 2020
@codecov
Copy link

codecov bot commented Mar 8, 2020

Codecov Report

Merging #423 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #423   +/-   ##
======================================
  Coverage    81.5%   81.5%           
======================================
  Files           7       7           
  Lines         530     530           
  Branches      152     152           
======================================
  Hits          432     432           
  Misses         70      70           
  Partials       28      28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2d2b88...7d538b0. Read the comment docs.

@stevengill stevengill merged commit 0ca1d5c into slackapi:master Mar 9, 2020
@seratch seratch deleted the issue-422 branch March 10, 2020 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiUsersSelectAction should have selected_users, not selected_user.
2 participants