Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning to deprecated methods #1395

Closed
omerkarpas opened this issue Aug 9, 2023 · 3 comments
Closed

Add deprecation warning to deprecated methods #1395

omerkarpas opened this issue Aug 9, 2023 · 3 comments
Labels
auto-triage-stale enhancement M-T: A feature request for new functionality semver:patch

Comments

@omerkarpas
Copy link

example below from slack_sdk/web/client.py

why not delete them are at least add docstr or a warning message to the log these are deprecated!


    # --------------------------
    # Deprecated: channels.*
    # You can use conversations.* APIs instead.
    # https://api.slack.com/changelog/2020-01-deprecating-antecedents-to-the-conversations-api
    # --------------------------

    def channels_archive(
        self,
        *,
        channel: str,
        **kwargs,
    ) -> SlackResponse:
        """Archives a channel."""
        kwargs.update({"channel": channel})
        kwargs = _remove_none_values(kwargs)
        return self.api_call("channels.archive", json=kwargs)
@filmaj filmaj added enhancement M-T: A feature request for new functionality semver:patch and removed untriaged labels Aug 9, 2023
@filmaj filmaj changed the title why does the code contains deprecated methods, and even without a warning... Add deprecation warning to deprecated methods Aug 9, 2023
@filmaj
Copy link
Contributor

filmaj commented Aug 9, 2023

Hey @omerkarpas , thanks for the suggestion! I think adding a deprecation warning to these old API methods is a good idea.

Feel free to send a PR! 🙇

@github-actions
Copy link

👋 It looks like this issue has been open for 30 days with no activity. We'll mark this as stale for now, and wait 10 days for an update or for further comment before closing this issue out. If you think this issue needs to be prioritized, please comment to get the thread going again! Maintainers also review issues marked as stale on a regular basis and comment or adjust status if the issue needs to be reprioritized.

@github-actions
Copy link

As this issue has been inactive for more than one month, we will be closing it. Thank you to all the participants! If you would like to raise a related issue, please create a new issue which includes your specific details and references this issue number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-triage-stale enhancement M-T: A feature request for new functionality semver:patch
Projects
None yet
Development

No branches or pull requests

2 participants