Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slackclient crashes with multidict 4.7.1 #582

Closed
4 of 9 tasks
kkagill opened this issue Dec 19, 2019 · 2 comments
Closed
4 of 9 tasks

slackclient crashes with multidict 4.7.1 #582

kkagill opened this issue Dec 19, 2019 · 2 comments
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented

Comments

@kkagill
Copy link

kkagill commented Dec 19, 2019

Description

slackclient 2.5.0 crashes with the recent version of multidict 4.7.1

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Bug Report

aio-libs/multidict#432
https://stackoverflow.com/questions/59350893/pyqt5-fbs-cant-execute-slack

Reproducible in:

slackclient version: 2.5.0

python version: 3.6.8

OS version(s): Widows 10 Pro

Steps to reproduce:

https://stackoverflow.com/questions/59350893/pyqt5-fbs-cant-execute-slack

Expected result:

What you expected to happen

Actual result:

What actually happened

Attachments:

Logs, screenshots, screencast, sample project, funny gif, etc.

@aoberoi
Copy link
Contributor

aoberoi commented Dec 19, 2019

It looks like you solved this issue by downgrading multidict to 4.6.1. That seems like a reasonable workaround until the downstream issue is fixed: aio-libs/multidict#432.

For anyone interested in helping fix this, please help out on the project above ☝️ . multidict is not a direct dependency of this package, its a transient dependency through aiohttp. We could declare a direct dependency to a pinned version (4.6.1) to get this workaround to more people, but I'd prefer not to do that unless there's no movement on multidict solving this issue for a little while.

Hopefully it will be patched soon. Thanks for reporting!

@aoberoi aoberoi added the bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented label Dec 19, 2019
@aoberoi aoberoi changed the title slack-client crashes with multidict 4.7.1 slackclient crashes with multidict 4.7.1 Dec 19, 2019
@seratch
Copy link
Member

seratch commented Apr 3, 2020

It seems the issue has been addressed since multidict 4.7.2. Allow me to close this issue now but if you see the issue is still happening with newer versions of multidict, please feel free to reopen this.
aio-libs/multidict@v4.7.1...v4.7.2

@seratch seratch closed this as completed Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented
Projects
None yet
Development

No branches or pull requests

3 participants