You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This looks like a pretty big landmine since the only differentiating factor is signedness of the second argument. (int align vs unsigned nelms)
This could be resolved by either renaming the first method from virtual void addAtAddress( Field f, unsigned nelms = DFLT_NELMS ) to virtual void addArrayAtAddress( Field f, unsigned nelms = DFLT_NELMS ), or by changing the type of int align to something that isn't implicitly convertible to an integral type. For example, Align_t which has an explicit constructor taking int.
Both solutions will require an audit of modules using CPSW
The text was updated successfully, but these errors were encountered:
Getting a lot of warnings like:
This looks like a pretty big landmine since the only differentiating factor is signedness of the second argument. (
int align
vsunsigned nelms
)This could be resolved by either renaming the first method from
virtual void addAtAddress( Field f, unsigned nelms = DFLT_NELMS )
tovirtual void addArrayAtAddress( Field f, unsigned nelms = DFLT_NELMS )
, or by changing the type ofint align
to something that isn't implicitly convertible to an integral type. For example,Align_t
which has an explicit constructor takingint
.Both solutions will require an audit of modules using CPSW
The text was updated successfully, but these errors were encountered: