Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - "Enter Fullscreen" Action Text Does Not Change #1127

Open
zdomke opened this issue Nov 6, 2024 · 0 comments · May be fixed by #1128
Open

[BUG] - "Enter Fullscreen" Action Text Does Not Change #1127

zdomke opened this issue Nov 6, 2024 · 0 comments · May be fixed by #1128
Assignees

Comments

@zdomke
Copy link
Contributor

zdomke commented Nov 6, 2024

Describe the bug
When a user enters fullscreen mode using the "Enter Fullscreen" action in the menubar, the text does not change.

Expected behavior
I would have expected the text to change to "Exit Fullscreen". Otherwise there is no action displayed to exit fullscreen mode.

Steps to Reproduce
Open a PyDM window with the menubar enabled, click "View" in the menubar, click "Enter Fullscreen", click "View" in the menubar again, and notice that the action is still labeled "Enter Fullscreen".

Possible Solution
In the file pydm/main_window.py, we can change the function PyDMMainWindow.enter_fullscreen() to also update the name of the action that calls it:

  • file: pydm/pydm_ui.py
  • property:Ui_MainWindow.actionEnter_Fullscreen
  • function: actionEnter_FullscreensetText()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants