Skip to content
This repository has been archived by the owner on Jun 15, 2023. It is now read-only.

PureScript 0.12 #54

Open
ninjarab opened this issue Sep 26, 2018 · 1 comment
Open

PureScript 0.12 #54

ninjarab opened this issue Sep 26, 2018 · 1 comment

Comments

@ninjarab
Copy link

As a bunch of dependencies have been deprecated, purescript-dom has been split up into a variety of projects within the purescript-web organization and purescript-eff has been deprecated in favour of purescript-effect (or purescript-run), is there any plan for upgrading the project?

I gave it a try on my own fork, see https://github.com/Ninjarab/purescript-echarts/pull/1/files, but I have no idea if this is the right approach. I’m willing to help, if I can, though I am still pretty new to PureScript. So please feel free to take a look and to leave some comments.

@cryogenian
Copy link
Member

We don't need it currently in SlamData, sorry 😞 I'll add proper review to the pr, but after brief look I think that you don't need to remove phantom rows from CommandT and DSL since this will allow to have items with axes, axes with series and other funny nonsense.

Thank you very much!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants