Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sometimes slap has one keystroke's worth of input lag on OSX iojs and node 0.12 (but not 0.10) #156

Closed
dbkaplun opened this issue May 2, 2015 · 6 comments
Closed

Sometimes slap has one keystroke's worth of input lag on OSX iojs and node 0.12 (but not 0.10) #156

dbkaplun opened this issue May 2, 2015 · 6 comments
Labels
bug

Comments

@dbkaplun
Copy link
Member

dbkaplun commented May 2, 2015

Maybe 10% of the time, when you're typing, the last keystroke isn't shown on the screen. After some debugging, I've found that the keypress is being registered, but stdout is simply not flushed. As it turns out, the whole event loop shuts down, i.e. setInterval callbacks stop getting called. However, as soon as I send any more data to stdin, the event loop works again and setInterval callbacks are called again, so it seems like a blocking read is the issue somewhere.
@dbkaplun dbkaplun added the bug label May 2, 2015
@dbkaplun dbkaplun changed the title slap has one keystroke's worth of input lag on iojs and node 0.12 (but not 0.10) Sometimes slap has one keystroke's worth of input lag on iojs and node 0.12 (but not 0.10) May 2, 2015
@dbkaplun dbkaplun changed the title Sometimes slap has one keystroke's worth of input lag on iojs and node 0.12 (but not 0.10) Sometimes slap has one keystroke's worth of input lag on OSX iojs and node 0.12 (but not 0.10) May 2, 2015
@dbkaplun dbkaplun changed the title Sometimes slap has one keystroke's worth of input lag on OSX iojs and node 0.12 (but not 0.10) ~10% of the time, slap has one keystroke's worth of input lag on OSX iojs and node 0.12 (but not 0.10) May 2, 2015
@dbkaplun dbkaplun changed the title ~10% of the time, slap has one keystroke's worth of input lag on OSX iojs and node 0.12 (but not 0.10) Sometimes slap has one keystroke's worth of input lag on OSX iojs and node 0.12 (but not 0.10) May 2, 2015
@dbkaplun dbkaplun mentioned this issue May 2, 2015
Closed
@steelbrain
Copy link

Bump

@dbkaplun
Copy link
Member Author

dbkaplun commented May 8, 2015

See also nodejs/node-v0.x-archive#9310 and libuv/libuv#304.

@dbkaplun
Copy link
Member Author

dbkaplun commented Jun 2, 2015

A fix has been merged into libuv. Soon!

@dbkaplun dbkaplun mentioned this issue Jun 9, 2015
Closed
@dbkaplun
Copy link
Member Author

Looks like this issue was fixed with Node 0.12.5. Please confirm!

@steelbrain
Copy link

@dbkaplun I am not in a position to confirm this slap bug for the next few months 😃
Sorry.

@dbkaplun
Copy link
Member Author

Closing. If issues continue, I will consider reopening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbkaplun @steelbrain