Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot compile with older GCCs #4

Open
coderforlife opened this issue Oct 3, 2017 · 0 comments
Open

Cannot compile with older GCCs #4

coderforlife opened this issue Oct 3, 2017 · 0 comments

Comments

@coderforlife
Copy link
Member

Since the flag -std=c++11 is used to compile the Cython modules older GCCs are not supported. For example, rocce needs -std=c++0x instead.

Additionally there are the following warnings which should be checked to see if they exist on newer GCCs or not:

cc1plus: warning: command line option "-Wstrict-prototypes" is valid for Ada/C/ObjC but not for C++
segtools/pysegtools/general/cython/npy_helper.h:216: warning: expected [error|warning|ignored] after '#pragma GCC diagnostic'
segtools/pysegtools/general/cython/npy_helper.h:234: warning: expected [error|warning|ignored] after '#pragma GCC diagnostic'

The _label.pyx file has several additional warnings related to the npy_helper:

pysegtools/images/filters/_label.cpp:2299: warning: invalid access to non-static data member 'half::raw'  of NULL object
pysegtools/images/filters/_label.cpp:2299: warning: (perhaps the 'offsetof' macro was used incorrectly)
pysegtools/images/filters/_label.cpp:2308: warning: invalid access to non-static data member 'complex<float>::R'  of NULL object
pysegtools/images/filters/_label.cpp:2308: warning: (perhaps the 'offsetof' macro was used incorrectly)
pysegtools/images/filters/_label.cpp:2309: warning: invalid access to non-static data member 'complex<float>::I'  of NULL object
pysegtools/images/filters/_label.cpp:2309: warning: (perhaps the 'offsetof' macro was used incorrectly)
pysegtools/images/filters/_label.cpp:2315: warning: invalid access to non-static data member 'complex<double>::R'  of NULL object
pysegtools/images/filters/_label.cpp:2315: warning: (perhaps the 'offsetof' macro was used incorrectly)
pysegtools/images/filters/_label.cpp:2316: warning: invalid access to non-static data member 'complex<double>::I'  of NULL object
pysegtools/images/filters/_label.cpp:2316: warning: (perhaps the 'offsetof' macro was used incorrectly)
pysegtools/images/filters/_label.cpp:2322: warning: invalid access to non-static data member 'complex<long double>::R'  of NULL object
pysegtools/images/filters/_label.cpp:2322: warning: (perhaps the 'offsetof' macro was used incorrectly)
pysegtools/images/filters/_label.cpp:2323: warning: invalid access to non-static data member 'complex<long double>::I'  of NULL object
pysegtools/images/filters/_label.cpp:2323: warning: (perhaps the 'offsetof' macro was used incorrectly)

But none of these should effect common usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant