Priorities

[Noobulater]

Great work so far

Living Issue so I'll update it as I think about it

Priority in order

• hovering-toolbar
• mentions
• scroll-into-view
• search-highlighting
• forced-layout
• markdown-shortcuts
• paste-html
• huge-document
• images
• iframe example #68 (BLOCKED by DOM elements in iframe portal are instantiated from top Window.Node instead of the iframe Window.Node #2358)
• markdown-preview
• plaintext
• styling
• shadow-dom (low priority)
• tables

[bmingles]

@Noobulater I pushed hovering toolbar example last night

[Noobulater]

Gave it a little inspection, everything looks to be in order. I checked out the slate editor state and the state seems to be mutating correctly!

Updated the priorities in the original post. Let's use this ticket for progress tracking, and this ticket for misc discussion about priorities and coordiantion. I'm doing some light investigation on the huge document stuff atm

[bmingles]

@Noobulater I'm not familiar with the scroll into view behavior. Can you give me an example scenario to test this behavior?

[Noobulater]

@bmingles

I have some old code that had buttons linked to headers as scrollable links, since there is no example on slate's website, I'll handle it by making a forked version of the huge document

Edit: So looking at my old implementation, it uses a HTMLElement.scrollIntoView, I'll see about putting it

    const { selection } = editor
    if (selection) {
      const range = ReactEditor.toDOMRange(editor, selection)
      if (range && !isInViewport(range.endContainer.parentElement))
        range.endContainer.parentElement.scrollIntoView({ inline: "end", block: "end" })
    }

[Noobulater]

I have a working example, I'll put it up for MR here in the next couple of days.

[bmingles]

FWIW, there is an example in the slate repo, it just doesn't seem to be exposed in the app: https://github.com/ianstormtaylor/slate/blob/main/site/examples/ts/scroll-into-view.tsx

I just wasn't sure how it was intended to work. Great if you have a working example though.

[bmingles]

@Noobulater I think I’ve worked through all of the examples + known issues (minus agredd upon exclusions like iframes). Would be good to get your input if there are any remaining priorities.

I’ve also published latest @slate-solid/core npm package

[Noobulater]

@bmingles Sounds good, will try to look at this week.