RequireCombinedAssignmentOperatorSniff: Fixed false positive

Author: kukulich

SlevomatCodingStandard/Sniffs/Operators/RequireCombinedAssignmentOperatorSniff.php

@@ -4,6 +4,7 @@
 
 use PHP_CodeSniffer\Files\File;
 use PHP_CodeSniffer\Sniffs\Sniff;
+use PHP_CodeSniffer\Util\Tokens;
 use SlevomatCodingStandard\Helpers\IdentificatorHelper;
 use SlevomatCodingStandard\Helpers\TokenHelper;
 use function array_key_exists;
@@ -18,6 +19,7 @@
 use const T_MULTIPLY;
 use const T_PLUS;
 use const T_POW;
+use const T_SEMICOLON;
 use const T_SL;
 use const T_SR;
 use const T_STRING_CONCAT;
@@ -90,6 +92,11 @@ public function process(File $phpcsFile, $equalPointer): void
 			return;
 		}
 
+		$semicolonPointer = TokenHelper::findNext($phpcsFile, T_SEMICOLON, $equalPointer + 1);
+		if (TokenHelper::findNext($phpcsFile, Tokens::$operators, $operatorPointer + 1, $semicolonPointer) !== null) {
+			return;
+		}
+
 		$fix = $phpcsFile->addFixableError(
 			sprintf('Use "%s" operator instead of "=" and "%s".', $operators[$tokens[$operatorPointer]['code']], $tokens[$operatorPointer]['content']),
 			$equalPointer,

tests/Sniffs/Operators/data/requireCombinedAssignmentOperatorNoErrors.php

@@ -33,5 +33,10 @@ public function shortList($array)
 		[$a, $b, $c, $d, $e] = $array + range(0, 4);
 	}
 
+	public function moreOperators($a, $b, $c)
+	{
+		$a = $a / $b / $c;
+	}
+
 }