Skip to content

Add node to ComplexityEstimatorArgs #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2021
Merged

Add node to ComplexityEstimatorArgs #46

merged 1 commit into from
Mar 18, 2021

Conversation

noc7c9
Copy link
Contributor

@noc7c9 noc7c9 commented Mar 17, 2021

This adds the node value to the estimator args to support more calculation use cases. Fixes #45

@noc7c9
Copy link
Contributor Author

noc7c9 commented Mar 17, 2021

Btw I noticed that eslint isn't seeing all the files. You probably want to run something like eslint --ext ts src/ instead of using globs.

ivome
ivome requested changes Mar 17, 2021
View reviewed changes
Copy link
Collaborator

@ivome ivome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you add some tests for that?

@noc7c9 noc7c9 requested a review from ivome March 17, 2021 13:11
@ivome ivome merged commit 3c37d91 into slicknode:master Mar 18, 2021
@ivome ivome mentioned this pull request Mar 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivome ivome Awaiting requested review from ivome

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: expose the node to estimators
2 participants
@noc7c9 @ivome