Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Body is still sent on 304 #54

Open
JimTools opened this issue Mar 7, 2024 · 1 comment · May be fixed by #55
Open

Body is still sent on 304 #54

JimTools opened this issue Mar 7, 2024 · 1 comment · May be fixed by #55

Comments

@JimTools
Copy link

JimTools commented Mar 7, 2024

There is odd behaviour around cache hits, the whole idea of the 304 status is to reduce data transmission if the browser/client has data which is still accurate.

I've noticed that the response body isn't truncated defeating the purpose, technically this isn't a bug nor an implementation issue I still think it's incorrect behaviour.

While the developers can work around this by handling it in their projects, I feel like this package should handle this.

RFC-9110
MDN 304

@JimTools JimTools linked a pull request Mar 7, 2024 that will close this issue
@odan
Copy link
Contributor

odan commented Jul 9, 2024

I think this could be handled very easy with a custom middleware. Check for the response status code == 304 and return a response with an empty response body.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants