Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error unmarshaling object data on DELETE operations with dynamic webhooks #63

Closed
slok opened this issue May 15, 2020 · 1 comment · Fixed by #64
Closed

Error unmarshaling object data on DELETE operations with dynamic webhooks #63

slok opened this issue May 15, 2020 · 1 comment · Fixed by #64
Assignees
Labels
bug Something isn't working

Comments

@slok
Copy link
Owner

slok commented May 15, 2020

Related:

Sometimes validation webhooks are used for delete operations. The delete operation admission request doesn't have a body of the object, Kubewebhook tries unmarshaling them and it fails.

We could use admission request OldObject instead.

@slok slok self-assigned this May 15, 2020
@slok slok added the bug Something isn't working label May 15, 2020
@slok
Copy link
Owner Author

slok commented May 16, 2020

Reproduced the problem from #62 (comment) in Integration tests: https://travis-ci.org/github/slok/kubewebhook/builds/687717249#L442

Only happens with the new dynamic webhooks.

@slok slok changed the title Delete operations can't be unmarshaled correctly Error unmarshaling object data on DELETE operations with dynamic webhooks May 16, 2020
@slok slok closed this as completed in #64 May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant