Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: distinction between builder and signer for generators and npm #735

Open
laurentsimon opened this issue Jan 13, 2024 · 0 comments
Open

Comments

@laurentsimon
Copy link
Contributor

laurentsimon commented Jan 13, 2024

There's a distinction to be made between the signer and the builder for sigstore-based CLIs (npm). We currently have two builders allowed for npm verification: github-hosted and self-hosted. This is giving a false sense of security, because this value (in the cert) only guarantees the runner on which signing took place, not the actual build.

I'm wondering if we should remove this distinction altogether to avoid mis-leading users. We would have a single builder id we accept, which is the generic "https://github.com/actions/runner" instead of accepting of

NpmCLIHostedBuilderID = NpmCLILegacyBuilderID + "/github-hosted"
// NpmCLISelfHostedBuilderID is the builder ID for the npm CLI on Self-hosted GitHub Actions.
NpmCLISelfHostedBuilderID = NpmCLILegacyBuilderID + "/self-hosted"

There is a similar problem with our generators. Except that we don't expose github-hosted vs self-hosted now. And we can fix this problem by resolving slsa-framework/slsa-github-generator#1868

@ramonpetgrave64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant