Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripted build requirement seems to imply config-as-code #157

Closed
msuozzo opened this issue Sep 13, 2021 · 4 comments
Closed

scripted build requirement seems to imply config-as-code #157

msuozzo opened this issue Sep 13, 2021 · 4 comments
Labels
clarification Clarification of the spec, without changing meaning

Comments

@msuozzo
Copy link
Contributor

msuozzo commented Sep 13, 2021

I think there needed to be some wording tweaks to Scripted Build included in #141. The current wording is as follows:

All build steps were fully defined in some sort of "build script". The only manual command, if any, was to invoke the build script.

This builder requirement has tick marks at all levels (i.e. it applies at L1-4).

#141 removed the requirement that a committed build script be used at L1-2 so, to my mind, the "manual command" bit no longer applies to all levels.

Given that this requirement is in the builder section, I see this requirement as trying to convey "build completeness" i.e. all steps that logically produce the output artifact are captured in the provenance. I think that sort of requirement is really valuable and is even more so now that L1-2 permits users to populate commands externally to source: We want those builds fully expressed in the recorded metadata.

To resolve this conflict, I think we can do one or more of the following:

  • Remove the sentence that talks about limiting manual commands.
  • Clarify or de-emphasize script to ensure the wording can apply to a recorded series of commands (e.g. L1) as easily as it can to a submitted script (L3+)
  • Rephrase the requirement to Build Completeness (or Script Completeness or something less clunky)
@msuozzo msuozzo added the clarification Clarification of the spec, without changing meaning label Sep 13, 2021
@TomHennen
Copy link
Contributor

My suggestion: remove the 'scripted build' requirement.

@msuozzo
Copy link
Contributor Author

msuozzo commented Sep 14, 2021

That's certainly an option. But unless "build completeness" is represented somewhere else in the ladder, it might be nice to have a dedicated line item to convey.

@06kellyjac
Copy link
Contributor

If 'scripted build' is no longer a requirement of L1 then all L1 has is 'Provenance - Available'

I feel like this conversation has started somewhere else already but I can't remember where

@MarkLodato
Copy link
Member

"Scripted build" has been removed as per #498, this issue is no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Clarification of the spec, without changing meaning
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants