Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slsa.dev style: missing space between paragraphs #335

Closed
MarkLodato opened this issue Mar 28, 2022 · 3 comments · Fixed by #548
Closed

slsa.dev style: missing space between paragraphs #335

MarkLodato opened this issue Mar 28, 2022 · 3 comments · Fixed by #548
Labels
shovel-ready Issues ready to be resolved website Issues with the slsa.dev website

Comments

@MarkLodato
Copy link
Member

The CSS on the slsa.dev website removes virtual whitespace between paragraphs, which makes it really hard to read. This is because (at least) there are two different rules that set p { margin: 0 }, one in main.css and one in tailwind.min.css. Adding a margin after the paragraph will fix it, though care must be taken to not break anything else. (I wish we had an easy visual diffing tool.)

If anyone wants to send out a PR to fix this, it would be most appreciated!

Example

https://slsa.dev/verification_summary/v0.1

Current:

missing space

Expected:

has space

@MarkLodato MarkLodato added website Issues with the slsa.dev website shovel-ready Issues ready to be resolved labels Mar 28, 2022
@MarkLodato
Copy link
Member Author

Tailwind also ruins <ol> tags by setting list-style: none. I think we need to get rid of tailwind and instead use proper css.

@MarkLodato
Copy link
Member Author

MarkLodato commented Apr 12, 2022

If we use add the markdown class (see #357 for example), it fixes most issues, but blockquote elements are formatted as horizontal boxes (flex model, different color, etc.). We'd need to fix that before applying that fix to the standards pages.

@MarkLodato
Copy link
Member Author

Also bulleted list spacing:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shovel-ready Issues ready to be resolved website Issues with the slsa.dev website
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant