Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problematic handling of LLVM arithmetic with overflow intrinsics #646

Open
shaobo-he opened this issue Nov 19, 2020 · 1 comment
Open

Problematic handling of LLVM arithmetic with overflow intrinsics #646

shaobo-he opened this issue Nov 19, 2020 · 1 comment

Comments

@shaobo-he
Copy link
Contributor

Current integer-overflow checking assertions are inserted whenever an LLVM arithmetic with overflow intrinsics occur. This is incorrect because such intrinsics are not necessarily used for integer-overflow checking. For example, __builtin_add_overflow is compiled to one of the intrinsics. We need to decouple the handling of these intrinsics with overflow checking.

@zvonimir
Copy link
Member

zvonimir commented Apr 2, 2021

I don't quite understand this issue. Are you saying we are injecting checks even when overflow checking is not enabled in the command line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants