-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VersionScheme.MAVEN version comparison fails #333
Comments
I posted this in the other thread:
This was also verified using 1.9.7 and 1.9.8. In light of this fact, I think this is not a bug, WDYT? |
I don't know, I believe that the absence of a predefined qualifier should assume Any thoughts @aloubyansky? |
Well, that would be nice. :-) However, Maven doesn't have any way to know whether you intend to put What we are doing, when we add our Addressing a syntactic weakness like this is actually very difficult, because if you do change the rules for this use case, then you will likely break some (or many) other use cases. Thus we have to look at bugs such as this one as "we made a wrong assumption about how this works" rather than "it doesn't work the way we want, so it should be fixed". In practice, I think adding a |
Here is an implementation from the Maven resolver, to compare.
results in
Where |
From the two implementations, I'd probably pick |
To be perfectly clear, my |
I'd say that Maven is wrong and so is Smallrye for not considering an empty milestone as a release during comparison 😀 |
Thank you both :) |
Given everything, I'm going to call this "not a bug". But we can reopen discussion if needed. |
Given that
3.8.0.redhat-00001
is less than3.8.0.SP1-redhat-00001
, the following snippet returns1
(expected is-1
):Originally posted by @gastaldi in #330 (comment)
The text was updated successfully, but these errors were encountered: