Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow schema without operations if Federation is enabled #2113

Closed
wants to merge 1 commit into from

Conversation

jmartisk
Copy link
Member

Fixes #2110

@jmartisk
Copy link
Member Author

@nicholassmith does this resolve your problem in #2110?

@nicholassmith
Copy link

I think it's a starting point, but after experimenting with manipulating the Operations when it invokes validateSchema in the GraphQLSchema::buildImpl() it's checking presence of a Query. Unfortunately that validate occurs prior to the Federation.transform which would populate the federation queries so it seems like some changes would be needed there as well.

@jmartisk
Copy link
Member Author

Ah, right, I didn't notice. In that case though, that's something that would need fixing in graphql-java (https://github.com/graphql-java/graphql-java) - perhaps start a discussion there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to generate Federation schema with no @Query functions
2 participants