Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for dark mode #81

Open
renecotyfanboy opened this issue Oct 31, 2023 · 1 comment
Open

No support for dark mode #81

renecotyfanboy opened this issue Oct 31, 2023 · 1 comment

Comments

@renecotyfanboy
Copy link

Unlike sphinx-gallery, the output representation captured with mkdocs-gallery does not change when using light/dark mode, making it hard to read in dark mode. See the following images for text and html repr :

Light-mode html :
image

Dark-mode html :
image

Light-mode text:
image

Dark-mode text:
image

This was fixed in sphinx-gallery/sphinx-gallery#948. I am sorry I have little experience with mkdocs and css in general so I might not be able to propose a PR for this

@smarie
Copy link
Owner

smarie commented Nov 23, 2023

Thanks a lot @renecotyfanboy , great proposal !

I guess that the dark mode you refer to is the dark mode from mkdocs-material ? https://squidfunk.github.io/mkdocs-material/setup/changing-the-colors/

It seems that their fix just involves modifying their CSS. https://github.com/sphinx-gallery/sphinx-gallery/pull/948/files

We do have the same equivalent CSS files on our side : https://github.com/smarie/mkdocs-gallery/tree/main/src/mkdocs_gallery/static

so it is "just" a matter of finding what is relevant to port.... and testing it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants