Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error popup on 'Help' > 'Equation Summary' #93

Closed
dracorpg opened this issue Apr 16, 2021 · 2 comments
Closed

Error popup on 'Help' > 'Equation Summary' #93

dracorpg opened this issue Apr 16, 2021 · 2 comments
Labels
Milestone

Comments

@dracorpg
Copy link
Contributor

Trying to reach the equation summary shows an error popup instead.

To Reproduce

  1. Click on 'Help' menu > 'Equation Summary'

Expected behavior
The PDF file with equations should be displayed :)

Screenshots
I'll dispense with an actual screenshot, it's a relatively bland error popup that reads:

A JavaScript error occured in the main process

Uncaught Exception:
TypeError: require(..).shell.openitem is not a function
at click ([PTree]\resources\app.asar\main.js:211:41)
at Menultem.click (electron/js2c/browser_init.js:73:1683)
at Object.a._executeCommand (electron/js2c/browser_init.js:81:2343)

Desktop (please complete the following information):

  • OS: Windows (also confirmed on Fedora)
  • Version: 2.0 (seems to be a regression from 1.8)
@smariel smariel added the bug label Apr 17, 2021
@smariel
Copy link
Owner

smariel commented Apr 17, 2021

Thanks !

shell.openItem() is no longer a function since Electron v9.0.0. A fix has to be found to open an external file with the default program. shell.openExternal() may be a solution.

For information, on Windows, the PDF file is located in the root folder of the application.

@dracorpg
Copy link
Contributor Author

From a cursory glance at the Electron doc, shell.openPath() looks to me like the most direct replacement for shell.openItem()
... and actually, 9.0 API breaking change notes say it's precisely the case: https://www.electronjs.org/blog/electron-9-0#api-changes :)

@smariel smariel added this to the v2.0.1 milestone Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants