Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential false negatives #31

Open
mxr opened this issue Nov 1, 2017 · 1 comment
Open

Potential false negatives #31

mxr opened this issue Nov 1, 2017 · 1 comment

Comments

@mxr
Copy link
Contributor

mxr commented Nov 1, 2017

The following code

from __future__ import print_function


def foo1(
    arg1, arg2, arg3, arg4,
):
    print(arg1, arg2, arg3, arg4)


def foo2(arg1, arg2, arg3, arg4, ):
    print(arg1, arg2, arg3, arg4)

passes flake8-strict checks. I was wondering if this was expected, or if both functions should be flagged. It's not quite an S100 violation but this code seems less ideal than having each arg on its own line or all args on the same line with the function name (and no trailing comma before the paren).

Thanks!

@JaimeLennox
Copy link
Contributor

I think this is expected, for now. We could probably add this as a new type of violation though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants