Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code duplication in getReports(), getReport() #27

Open
tomasholderness opened this issue Nov 19, 2015 · 0 comments
Open

Code duplication in getReports(), getReport() #27

tomasholderness opened this issue Nov 19, 2015 · 0 comments
Assignees
Milestone

Comments

@tomasholderness
Copy link
Contributor

JS & SQL code in these two functions is now near equivalent, potentially could be collapsed into one method which optional parameters as required.

-> This is important because currently getReport() does not return all parameters for a true representation of a report, potentially breaking client side processing of report objects if they expect complete object as returned by getReports().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants