Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow an inline-only mode for DocRef attachments #19

Open
mikix opened this issue Oct 10, 2023 · 0 comments
Open

Allow an inline-only mode for DocRef attachments #19

mikix opened this issue Oct 10, 2023 · 0 comments

Comments

@mikix
Copy link
Contributor

mikix commented Oct 10, 2023

User problem

I want to bulk export & archive DocumentReferences from my EHR while inlining attachments I know I'll care about in the future. This is both so that I have an archival record of the attachments I'm using right now and in case the EHR becomes unavailable in the future, I can still continue to refer back to the attachments.

However, I don't care about most mimetypes. I really only want html & text. PDFs, RTFs, etc will not be interesting to me, and will just take a long time to download.

Proposed fix

Instead of having the "inline attachment" logic be a subset of the "download attachment" logic, make them sibling paths. i.e. allow an inline-only mode where we don't bother download an attachment that is marked as a pdf in the FHIR record.

How would you like to see the user configuration for such a mode be done? (i.e. a new option like inlineOnly or re-use existing configuration and just start paying attention to inlineDocRefAttachmentsSmallerThan even if downloadAttachments is false?

I have some code that I'm testing for my own purposes to do this, and I can propose a PR later. But it will likely need some tweaking to fit your preferred configuration changes to allow for "inline only".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant