Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce unmount method. #53

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Introduce unmount method. #53

merged 1 commit into from
Jan 8, 2020

Conversation

sankethkatta
Copy link
Contributor

Add unmount() method to remove message event listener from the window.

@sankethkatta sankethkatta requested a review from jia-guo January 8, 2020 00:37
@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #53 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #53   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          15     15           
  Branches        2      2           
=====================================
  Hits           15     15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daca4b7...a054b97. Read the comment docs.

jia-guo
jia-guo approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@jia-guo jia-guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clearly thought. Thanks so much for walking me through!

@sankethkatta sankethkatta merged commit 8946f70 into master Jan 8, 2020
@sankethkatta sankethkatta deleted the unmount branch January 8, 2020 01:26
sankethkatta added a commit that referenced this pull request Jan 8, 2020
@sankethkatta
feat: Merge pull request #53 from smartcar/unmount
a542baf 
Introduce unmount method.
sankethkatta added a commit that referenced this pull request Jan 8, 2020
@sankethkatta
feat: Merge pull request #53 from smartcar/unmount
9524c4a 
Introduce unmount method.
@smartcar-ci
Copy link

🎉 This PR is included in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jia-guo jia-guo jia-guo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sankethkatta @smartcar-ci @jia-guo