Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(smartcar): added support for simulated mode and feature flags #70

Merged
merged 3 commits into from
Jul 21, 2022

Conversation

mdheri
Copy link
Contributor

@mdheri mdheri commented Jul 19, 2022

Adding support for simulated mode and compatibility feature flags

Asana: https://app.asana.com/0/1202541719267260/1202555728616912/f

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #70 (734a720) into master (e7aa0ab) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #70   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            9         9           
  Branches         2         2           
=========================================
  Hits             9         9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7aa0ab...734a720. Read the comment docs.

@mdheri mdheri requested a review from gurpreetatwal July 20, 2022 13:27
Copy link
Contributor

@gurpreetatwal gurpreetatwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, but otherwise looks good!

@mdheri mdheri merged commit 2a7e162 into master Jul 21, 2022
@mdheri mdheri deleted the add-simulated-mode-support branch July 21, 2022 07:18
mdheri added a commit that referenced this pull request Jul 21, 2022
@smartcar-ci
Copy link

🎉 This PR is included in version 2.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants