Skip to content

update default null chainId value #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Unheilbar wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

update default null chainId value #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8e2b9b0
update default null chainId value
Unheilbar Apr 8, 2025
156c3e1
update default chain id in tests
Unheilbar Apr 8, 2025
e25a5d3
Merge branch 'main' into geth_update
Unheilbar Apr 9, 2025
be9134e
rid of Sprint
Unheilbar Apr 9, 2025
ce7ec3a
cleanup
Unheilbar Apr 9, 2025
c5729ec
Merge remote-tracking branch 'origin/main' into geth_update
jmank88 Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .tool-versions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
golang 1.24.1
3 changes: 2 additions & 1 deletion multinode/send_only_node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"
"fmt"
"net/url"
"strconv"
"sync"

"github.com/smartcontractkit/chainlink-common/pkg/logger"
Expand Down Expand Up @@ -111,7 +112,7 @@ func (s *sendOnlyNode[CHAIN_ID, RPC]) start() {
}
s.setState(nodeStateDialed)

if s.chainID.String() == "0" {
if s.chainID.String() == strconv.Itoa(NullClientChainID) {
// Skip verification if chainID is zero
s.log.Warn("sendonly rpc ChainID verification skipped")
} else {
Expand Down
4 changes: 2 additions & 2 deletions multinode/send_only_node_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,13 @@ func TestStartSendOnlyNode(t *testing.T) {
tests.AssertEventually(t, func() bool { return s.State() == nodeStateUnusable })
tests.RequireLogMessage(t, observedLogs, "Dial failed: SendOnly Node is unusable")
})
t.Run("Default ChainID(0) produces warn and skips checks", func(t *testing.T) {
t.Run("Default ChainID(1399100) produces warn and skips checks", func(t *testing.T) {
t.Parallel()
lggr, observedLogs := logger.TestObserved(t, zap.WarnLevel)
client := newMockSendOnlyClient[ID](t)
client.On("Close").Once()
client.On("Dial", mock.Anything).Return(nil).Once()
s := NewSendOnlyNode(lggr, makeMockNodeMetrics(t), url.URL{}, t.Name(), NewIDFromInt(0), client)
s := NewSendOnlyNode(lggr, makeMockNodeMetrics(t), url.URL{}, t.Name(), NewIDFromInt(1399100), client)

defer func() { assert.NoError(t, s.Close()) }()
err := s.Start(tests.Context(t))
Expand Down
2 changes: 2 additions & 0 deletions multinode/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ import (
"github.com/jpillora/backoff"
)

const NullClientChainID = 1399100
Copy link
Collaborator

@jmank88 jmank88 Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did this value come from?


func RandomID() ID {
// #nosec G404
id := rand.Int63n(math.MaxInt32) + 10000
Expand Down
Loading