Merge pull request #25 from smartcontractkit/zp-responselistener-patch

KuphJr · web-flow · commit 572b02b3390d · 2023-09-27T09:41:28.000-05:00
diff --git a/src/ResponseListener.ts b/src/ResponseListener.ts
@@ -59,9 +59,13 @@ export class ResponseListener {
   }
 
   public listenForResponses(
-    subscriptionId: number,
+    subscriptionId: number | string,
     callback: (functionsResponse: FunctionsResponse) => any,
   ) {
+    if (typeof subscriptionId === 'string') {
+      subscriptionId = Number(subscriptionId)
+    }
+
     this.functionsRouter.on(
       'RequestProcessed',
       (
diff --git a/test/integration/ResponseListener.test.ts b/test/integration/ResponseListener.test.ts
@@ -138,7 +138,8 @@ describe('Functions toolkit classes', () => {
         responseEventEmitter.emit('response')
       }
 
-      functionsListener.listenForResponses(subscriptionId, responseCallback)
+      const subIdString = subscriptionId.toString()
+      functionsListener.listenForResponses(subIdString, responseCallback)
 
       await exampleClient.sendRequest(
         'return Functions.encodeUint256(1)',

Original file line number	Diff line number	Diff line change
`@@ -59,9 +59,13 @@ export class ResponseListener {`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`public listenForResponses(`
`62`		`- subscriptionId: number,`
	`62`	`+ subscriptionId: number \| string,`
`63`	`63`	`callback: (functionsResponse: FunctionsResponse) => any,`
`64`	`64`	`) {`
	`65`	`+ if (typeof subscriptionId === 'string') {`
	`66`	`+ subscriptionId = Number(subscriptionId)`
	`67`	`+ }`
	`68`	`+`
`65`	`69`	`this.functionsRouter.on(`
`66`	`70`	`'RequestProcessed',`
`67`	`71`	`(`
Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,8 @@ describe('Functions toolkit classes', () => {`
`138`	`138`	`responseEventEmitter.emit('response')`
`139`	`139`	`}`
`140`	`140`
`141`		`- functionsListener.listenForResponses(subscriptionId, responseCallback)`
	`141`	`+ const subIdString = subscriptionId.toString()`
	`142`	`+ functionsListener.listenForResponses(subIdString, responseCallback)`
`142`	`143`
`143`	`144`	`await exampleClient.sendRequest(`
`144`	`145`	`'return Functions.encodeUint256(1)',`