Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove web3 dependencies #24

Closed
PatrickAlphaC opened this issue Jun 30, 2021 · 6 comments
Closed

Remove web3 dependencies #24

PatrickAlphaC opened this issue Jun 30, 2021 · 6 comments
Labels
good first issue Good for newcomers Hacktoberfest

Comments

@PatrickAlphaC
Copy link
Contributor

We should use ethers in this starter kit and not web3
@pappas999 pappas999 added the good first issue Good for newcomers label Sep 20, 2021
@Rishabh42
Copy link
Contributor

I'd like to work on this issue, is there anything else that I need to know?

@pappas999
Copy link
Collaborator

pappas999 commented Oct 18, 2021 •
edited
Loading

awesome to hear! nothing else to know @Rishabh42 , just need to remove references to web3.js and use ethers.js instead

@Rishabh42
Copy link
Contributor

Got it, thanks @pappas999 !

@Rishabh42
Copy link
Contributor

Hey @pappas999 , I have opened this PR for this issue: #49

Please review and let me know if anything else is required

Cheers

@Rishabh42
Copy link
Contributor

Greetings @pappas999!
I saw that this issue is still open even though my PR was merged into master.
Pls let me know if there's anything else that's required for this.

@PatrickAlphaC
Copy link
Contributor Author

Closing, thanks again @Rishabh42 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Rishabh42 @pappas999 @PatrickAlphaC