Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media template bugs #182

Closed
NicoleYarroch opened this issue Jul 23, 2019 · 4 comments
Closed

Media template bugs #182

NicoleYarroch opened this issue Jul 23, 2019 · 4 comments
Labels
bug

Comments

@NicoleYarroch
Copy link
Contributor

  1. If app's appHMIType is not MEDIA attempting to set the media template using SetDisplayLayout should fail. Currently it succeeds.
  2. If app's appHMIType is not MEDIA, the MEDIA template should not be in templatesAvailable returned by the RAI response. Currently, the MEDIA template is returned even when the app type is non-media (i.e. COMMUNICATION)
@jacobkeeler
Copy link
Contributor

I would agree that this probably makes sense in most cases, but I do wonder whether it is really necessary for the HMI to be strict on this matter

@joeygrover
Copy link
Member

@JackLivio can you look at this?

@iCollin iCollin mentioned this issue Aug 11, 2021
Merged
1 task
@iCollin
Copy link
Collaborator

iCollin commented Aug 11, 2021

I do not agree with #2. The capabilities in RAI response are NOT app specific and therefore do not depend on an app's HMI type.

A fix for #1 is available in #419

@iCollin
Copy link
Collaborator

iCollin commented Aug 13, 2021

Closed via #419

@iCollin iCollin closed this as completed Aug 13, 2021
@Jack-Byrne Jack-Byrne mentioned this issue Sep 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@joeljfischer @joeygrover @jacobkeeler @iCollin @NicoleYarroch