-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build fails if -DEXTENDED_MEDIA_MODE=ON #890
Comments
@yang1070 Working on this, I believe I have fixed all of the issues with the build and will likely be submitting a PR for it later this week |
@jacobkeeler How do you set up the GStreamer? I mean the include path and link libs. I changed the code locally to remove the connection_handler error. Then I met a "utils/logger.h" file cannot find error. I think somehow the FindGstreamer-1.0.cmake file in the project should be called to setup the Macro, but I didn't figure out how. |
@yang1070 The connection_handler issue should have been fixed with the merge of #880. I went through all of the build issues and fixed them in #900, so the changes in that PR should fix your issues. Note that you will need to manually specify the gstreamer directory as well:
|
@jacobkeeler Thank you very much for the quick response. The pull request #880 and #900 together do fix the build and core crash issue. |
Fixed with #900 |
[ 95%] Building CXX object src/components/media_manager/CMakeFiles/MediaManager.dir/src/media_manager_impl.cc.o
In file included from /home/zhimin/github/sdl_core/src/components/media_manager/src/media_manager_impl.cc:45:0:
/home/zhimin/github/sdl_core/src/components/media_manager/include/media_manager/audio/a2dp_source_player_adapter.h: In member function ‘void media_manager::A2DPSourcePlayerAdapter::set_connection_handler(connection_handler::ConnectionHandlerImpl_)’:
/home/zhimin/github/sdl_core/src/components/media_manager/include/media_manager/audio/a2dp_source_player_adapter.h:63:5: error: ‘connection_handler_’ was not declared in this scope
connection_handler_ = connection_handler;
^
src/components/media_manager/CMakeFiles/MediaManager.dir/build.make:158: recipe for target 'src/components/media_manager/CMakeFiles/MediaManager.dir/src/media_manager_impl.cc.o' failed
make[2]: *_* [src/components/media_manager/CMakeFiles/MediaManager.dir/src/media_manager_impl.cc.o] Error 1
CMakeFiles/Makefile2:2429: recipe for target 'src/components/media_manager/CMakeFiles/MediaManager.dir/all' failed
make[1]: *** [src/components/media_manager/CMakeFiles/MediaManager.dir/all] Error 2
Makefile:127: recipe for target 'all' failed
make: *** [all] Error 2
this happens in release/4.2.0, and mater with tag 4.1.0, 4.1.1. Didn't try other tags.
The text was updated successfully, but these errors were encountered: