Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDL 0219] Explicit returned type from NSDictionary(Store) category #1198

Closed
theresalech opened this issue Mar 19, 2019 · 0 comments
Closed
Labels
proposal Accepted SDL Evolution Proposal
Milestone

Comments

@theresalech
Copy link
Contributor

Proposal: Explicit returned type from NSDictionary(Store) category

This proposal is to specify returned types from NSDictionary (Store). This ensures that the return value is assigned to a variable of the correct type.

Review: smartdevicelink/sdl_evolution#685

Steering Committee Decision:

The Steering Committee voted to accept this proposal with revisions. The Revisions will include changing the method signature to the one that returns an error noted in this comment, so in the case of an error the NSError object could return the original data and an error message, or in the future, a fallback object for mandatory parameters.
The revisions will also need to state that optional parameters will log the error and assert in DEBUG, then return nil, and for mandatory parameters we will log the error, and assert in DEBUG, but will continue to return the bad object for now.
The proposal .md file was updated to reflect these revisions on 3/19/19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Accepted SDL Evolution Proposal
Projects
None yet
Development

No branches or pull requests

2 participants