Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate logic for saving the dynamic mtu size #1615

Closed
NicoleYarroch opened this issue Apr 2, 2020 · 0 comments
Closed

Consolidate logic for saving the dynamic mtu size #1615

NicoleYarroch opened this issue Apr 2, 2020 · 0 comments
Assignees
@FrankElias77
Labels
best practice Not a defect but something that should be improved anyway manager-lifecycle Relating to the manager layer - lifecycle manager

Comments

@NicoleYarroch
Copy link
Contributor

Bug Report

The dynamic mtu size for SDLServiceTypeRPC is saved in the SDLProtocol class, while the streaming audio and video managers save it in their own respective classes. It would make sense to consolidate saving the dynamic mtu size in the handleProtocolStartServiceACKMessage: method of the SDLProtocol class.

OS & Version Information
  • iOS Version: n/a
  • SDL iOS Version: 6.5
  • Testing Against: n/a
@NicoleYarroch NicoleYarroch added the best practice Not a defect but something that should be improved anyway label Apr 2, 2020
@joeljfischer joeljfischer added the manager-lifecycle Relating to the manager layer - lifecycle manager label Jul 8, 2020
@FrankElias77 FrankElias77 mentioned this issue Sep 3, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrankElias77 FrankElias77

Labels
best practice Not a defect but something that should be improved anyway manager-lifecycle Relating to the manager layer - lifecycle manager
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joeljfischer @NicoleYarroch @FrankElias77