Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The secondary transport manager should not start a timer when the primary transport opens #1716

Closed
NicoleYarroch opened this issue Jul 17, 2020 · 0 comments
Assignees
Labels
bug A defect in the library transport-secondary Relating to the secondary transport

Comments

@NicoleYarroch
Copy link
Contributor

Bug Report

When the primary transport opens, the SDLSecondaryTransportManager is notified via the onProtocolOpened delegate method. The SDLSecondaryTransportManager starts a timer to watch for a response to the request to register the secondary transport even though no such request can be sent due to the secondary transport not being established.

Reproduction Steps
  1. Connect a navigation app that supports secondary transports to the module.
  2. The registerTransportTimer on the SDLSecondaryTransportManager will be started as soon as the primary transport is established. If the secondary transport is not established by the time timer elapses, then irrelevant logs are printed.
Expected Behavior

The registerTransportTimer should only be created if the secondary transport has been established.

Observed Behavior

The registerTransportTimer is created even if the secondary transport has not been established.

OS & Version Information
  • iOS Version: n/a
  • SDL iOS Version: 6.6
  • Testing Against: SdlTcpApp
@NicoleYarroch NicoleYarroch self-assigned this Jul 17, 2020
@NicoleYarroch NicoleYarroch added bug A defect in the library transport-secondary Relating to the secondary transport labels Jul 17, 2020
@NicoleYarroch NicoleYarroch changed the title The secondary transport manager attempts to register the secondary transport when the primary transport opens The secondary transport manager not start a timer when the primary transport opens Jul 17, 2020
@NicoleYarroch NicoleYarroch changed the title The secondary transport manager not start a timer when the primary transport opens The secondary transport manager should not start a timer when the primary transport opens Jul 17, 2020
@joeljfischer joeljfischer mentioned this issue Jul 21, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library transport-secondary Relating to the secondary transport
Projects
None yet
Development

No branches or pull requests

2 participants