Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock Screen not dismissible #1948

Closed
FrankElias77 opened this issue Mar 19, 2021 · 1 comment · Fixed by #1949
Closed

Lock Screen not dismissible #1948

FrankElias77 opened this issue Mar 19, 2021 · 1 comment · Fixed by #1949
Assignees
@FrankElias77
Labels
bug A defect in the library manager-lockscreen Relating to the manager layer - lockscreen

Comments

@FrankElias77
Copy link
Contributor

FrankElias77 commented Mar 19, 2021 •
edited by NicoleYarroch
Loading

Bug Report

The lock screen should be dismissible in case DriverDistraction mode was OFF, enableDismissGesture was set to true and the lock screen's display mode is always.

Reproduction Steps
  1. Set lockscreen config display mode to always
  2. The default lock screen should appear correctly when the app is connected to Core with DD_OFF
  3. TurnDD_ON
  4. Turn DD_OFF again
  5. Swipe to dismiss lock screen
Expected Behavior

Lock screen should be dismissable

Observed Behavior

Lock screen is not dismissable

OS & Version Information
  • iOS Version: N/A
  • SDL iOS Version: Branch develop
  • Testing Against: Manticore
@FrankElias77 FrankElias77 added bug A defect in the library manager-lockscreen Relating to the manager layer - lockscreen labels Mar 19, 2021
@FrankElias77 FrankElias77 mentioned this issue Mar 19, 2021
Merged
4 tasks
@FrankElias77 FrankElias77 self-assigned this Mar 19, 2021
@NicoleYarroch
Copy link
Contributor

Fixed in PR #1949

@NicoleYarroch NicoleYarroch linked a pull request Apr 6, 2021 that will close this issue
Fix for lock screen not dismissible bug #1949
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrankElias77 FrankElias77

Labels
bug A defect in the library manager-lockscreen Relating to the manager layer - lockscreen
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for lock screen not dismissible bug smartdevicelink/sdl_ios
2 participants
@NicoleYarroch @FrankElias77