Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDLManager's stop does not stop the proxy. #509

Closed
asm09fsu opened this issue Jan 20, 2017 · 0 comments · Fixed by #510
Closed

SDLManager's stop does not stop the proxy. #509

asm09fsu opened this issue Jan 20, 2017 · 0 comments · Fixed by #510
Labels
bug A defect in the library

Comments

@asm09fsu
Copy link
Contributor

Bug Report

Currently, if a developer was to call stop on SDLManager (for some reason), the proxy will disconnect, however will also attempt reconnect. This is not correct, as according to the documentation in the header:

Stop the manager, it will disconnect if needed and no longer look for a connection. You probably don't need to call this method ever.

Reproduction Steps
  1. Start the manager.
  2. Notice connection on Core.
  3. Stop the manager.
  4. App disconnects, then reconnects.
Expected Behavior

The proxy should stop, and not attempt to reconnect.

Observed Behavior

The proxy stops, however does reconnect.

OS & Version Information
  • SDL iOS Version: 4.5.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A defect in the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated stop method of SDLManager to actually stop. smartdevicelink/sdl_ios
1 participant
@asm09fsu