Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force IAPSession assert on main queue #831

Closed
joeljfischer opened this issue Dec 20, 2017 · 0 comments
Closed

Force IAPSession assert on main queue #831

joeljfischer opened this issue Dec 20, 2017 · 0 comments
Assignees
Labels
bug A defect in the library
Milestone

Comments

@joeljfischer
Copy link
Contributor

joeljfischer commented Dec 20, 2017

Bug Report

The IAPSession `stop code currently contains the following line:

NSAssert([NSThread isMainThread], @"stop must be called on the main thread");

However, due to the RPC response queue changes in #813 we are seeing rare cases where stop will be called off the main thread. We should wrap it to force it onto the main queue if it is not via dispatch_sync to ensure timing remains the same.

Reproduction Steps

Unknown

Expected Behavior

The stop succeeds

Observed Behavior

The stop fails

OS & Version Information
  • iOS Version: n/a
  • SDL iOS Version: 5.1.0 develop
  • Testing Against: TDK
@joeljfischer joeljfischer added the bug A defect in the library label Dec 20, 2017
@joeljfischer joeljfischer added this to the 5.1.0 milestone Dec 20, 2017
@joeljfischer joeljfischer self-assigned this Dec 20, 2017
@joeljfischer joeljfischer changed the title Force IAPTransport assert on main queue Force IAPSession assert on main queue Dec 20, 2017
@joeljfischer joeljfischer mentioned this issue Jan 10, 2018
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library
Projects
None yet
Development

No branches or pull requests

1 participant