Pan gesture blocks single taps #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is ready for review |
|
@joeljfischer please review this PR. |
joeljfischer
changed the title
|
Hi @Lievesley, thanks for the revised PR. Everything looks good from an overview. I just need some advice on if we can merge this as a bug or if we need an SDLC proposal. I'll let you know. |
|
@joeljfischer what is the process for approving the SDLC proposal and how long will this take? |
joeljfischer
suggested changes
Mar 6, 2018
SmartDeviceLink/SDLTouchManager.m
Outdated
| CGFloat xDelta = fabs(touch.location.x - self.firstTouch.location.x); | ||
| CGFloat yDelta = fabs(touch.location.y - self.firstTouch.location.y); | ||
| if (xDelta <= self.panDistanceThreshold && yDelta <= self.panDistanceThreshold) | ||
| { |
There was a problem hiding this comment.
Stylistically, this project uses braces on the same line.
|
@joeljfischer requested change to opening brace is ready for review. |
NicoleYarroch
approved these changes
Mar 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #879
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
I already added the test case: 'when receiving a single tap with small movement'
Summary
Added a pan threshold distance to prevent pan gestures being recognised for small movements.
CLA