Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail because current code state doesn't match MOBILE_API #1597

Closed
bilal-alsharifi opened this issue Jan 11, 2021 · 0 comments
Closed
Labels
bug A defect in the library testing Relating to unit testing or smoke testing

Comments

@bilal-alsharifi
Copy link
Contributor

Bug Report

RPCGenericTests checks for deprecation mismatches between code and specs. The tests fail in some feature branches because the RPC spec submodule points to master and not to the feature branch in RPC spec. So any deprecations that are in code but not in RPC spec master branch will cause a failure.

Reproduction Steps
  1. Run unit tests in branches that make changes to RPCs like this one for example [0255] Enchance body information #1583
Expected Behavior

Unit tests pass

Observed Behavior

Unit tests fail with the following errors:

junit.framework.AssertionFailedError: There are 8 errors: 
[BodyInformation.setDriverDoorAjar() deprecation status does not match RPC spec. 
, BodyInformation.getDriverDoorAjar() deprecation status does not match ...
...
OS & Version Information
  • Android Version: N/A
  • SDL Android Version: 5.0.0
@bilal-alsharifi bilal-alsharifi added bug A defect in the library testing Relating to unit testing or smoke testing labels Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library testing Relating to unit testing or smoke testing
Projects
None yet
Development

No branches or pull requests

2 participants