Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyboardListener method for InputMask is misaligned #419

Closed
renonick87 opened this issue Mar 29, 2021 · 1 comment · Fixed by #420
Closed

KeyboardListener method for InputMask is misaligned #419

renonick87 opened this issue Mar 29, 2021 · 1 comment · Fixed by #420
Labels
best practice Not a defect but something that should be improved anyway

Comments

@renonick87
Copy link
Contributor

Bug Report

The KeyboardListener method called when the input mask has been changed is misaligned with the other libraries. onKeyboardInputMaskHasChanged should be onKeyboardDidUpdateInputMask.

Expected Behavior

The method and its setter should use onKeyboardDidUpdateInputMask.

Observed Behavior

The method and its setter uses onKeyboardInputMaskHasChanged.
@renonick87 renonick87 mentioned this issue Mar 29, 2021
Merged
5 tasks
@jordynmackool jordynmackool added the best practice Not a defect but something that should be improved anyway label Mar 29, 2021
@renonick87
Copy link
Contributor Author

Closed by #420.

@crokita crokita mentioned this issue Apr 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
best practice Not a defect but something that should be improved anyway
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Align Keyboard Listener smartdevicelink/sdl_javascript_suite
2 participants
@renonick87 @jordynmackool