Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC Spec submodule commit needs to be updated to the latest commit #463

Closed
renonick87 opened this issue Jun 17, 2021 · 1 comment
Closed
Labels
1.4 Release Issue found during 1.4 Release Candidate Review bug Something isn't working

Comments

@renonick87
Copy link
Contributor

Bug Report

The RPC Spec submodule is not pointing to the correct commit and is referencing a commit before the 7.1.0 release. If the library is rebuilt from this submodule then it will be missing RPC updates that were included in the 7.1.0 release.

Reproduction Steps
  1. Checkout the sdl_javascript_suite repo.
  2. Run git submodule init and git submodule update in a terminal window.
Expected Behavior

The RPC Spec submodule is pointing to the 7.1.0 release of the RPC Spec.

Observed Behavior

The RPC Spec submodule is not pointing to the 7.1.0 release of the RPC Spec.

@jordynmackool jordynmackool added the bug Something isn't working label Jun 21, 2021
@renonick87
Copy link
Contributor Author

Closed by #464

@jordynmackool jordynmackool added the 1.4 Release Issue found during 1.4 Release Candidate Review label Jun 21, 2021
@crokita crokita mentioned this issue Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.4 Release Issue found during 1.4 Release Candidate Review bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants