Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty else clauses; Redeclared variables; Unusued variables #33

Open
aarenson opened this issue Apr 7, 2020 · 1 comment
Open

Empty else clauses; Redeclared variables; Unusued variables #33

aarenson opened this issue Apr 7, 2020 · 1 comment

Comments

@aarenson
Copy link

aarenson commented Apr 7, 2020

We ran Multilingual through a series of static code checkers. A few minor items were pointed out that seemed worthy of bringing to your attention. None of these are likely to cause major problems.

Empty else clauses (2):

  • multilingual.js, line 228
  • multilingual_survey.js, line 659

Redeclared variables (20), not listing all of these, but as an example:

  • multilingual_setup.js, line 215, var_id

Unused variables (11):
multilingual.js
Line 186, counter

multilingual_pdf.js
Line 16, lang
Line 24, lang

multilingual_setup.js
line 7, setup
line 8, settings

multilingual_survey.js
line 7, project_id
line 403, showSymbols
line 594, counter

multilingual_survey_return.js
line 6, project_id
line 9, totalLanguages
line 234, setNormalCookie

@smartinkc
Copy link
Owner

I appreciate this. This thing has been through so many iterations from a plugin to module. I need to set aside time to clean it up when I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants