Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openapi3 query parameter parsing does not work correctly #282

Open
sakari opened this issue Dec 10, 2021 · 0 comments
Open

Openapi3 query parameter parsing does not work correctly #282

sakari opened this issue Dec 10, 2021 · 0 comments

Comments

@sakari
Copy link
Collaborator

sakari commented Dec 10, 2021

Currently oats depends on the adapters to marshal query parameters in the url to the query parameter object passed to the runtime checker. There is no way for the query parameter formatting specified in the openapi spec to be used for the parsing of the query parameter -- we are wholly dependant on how the adapter is configured to parse the query parameters.

In addition to not being really compliant with openapi3 this causes behaviour differences between the adapters, eg mirage and koa parse the query parameters differently.

To solve this we could move the query parameter parsing to the oats side so that we can ensure that the behaviour is the same for all adapters.

See "Query parameters" in https://swagger.io/docs/specification/serialization/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant