Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Java 17 #91

Open
ronreynolds opened this issue Jun 21, 2024 · 3 comments
Open

Update to Java 17 #91

ronreynolds opened this issue Jun 21, 2024 · 3 comments

Comments

@ronreynolds
Copy link
Collaborator

No description provided.

@ronreynolds
Copy link
Collaborator Author

converted this to an issue so i can add comments (apparently that's not possible until it's made an issue).
per standup i really think we should only upgrade the JDK version with great care and intention since we're telling our SDK customers that they MUST use this version or better in order to use the SDK jar. Java-11 seems reasonable (tho many projects are still stuck in Java-8) but Java-17 seems excessive to me.

@ronreynolds
Copy link
Collaborator Author

also found this regarding team communication best practices on github - https://docs.github.com/en/discussions/guides/best-practices-for-community-conversations-on-github
haven't read it all yet.

@ronreynolds
Copy link
Collaborator Author

another MR updates the BUILD to work with Java-21's javac but the CODE is still Java-11 compliant and the build is still generating Java-11 bytecodes, which i think is crucial if we don't want to upset users by forcing them to upgrade to a newer JVM without a very good set of reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant