Skip to content
This repository has been archived by the owner on Aug 14, 2018. It is now read-only.

Does not support API Gateway with custom host names #26

Open
jdonboch opened this issue Sep 10, 2015 · 4 comments
Open

Does not support API Gateway with custom host names #26

jdonboch opened this issue Sep 10, 2015 · 4 comments

Comments

@jdonboch
Copy link

With API Gateway, you need to sign your URL if you have AWS_IAM authentication enabled and this would be a great service to use if it supported it. Unfortunately, if you are using custom domain with API Gateway, you can't derive the service and region from the URL like you can with other API requests. There should be another method similar to Sign4 that allows the user to manually provide the region and service (execute-api for API Gateway).

@chiefy
Copy link

chiefy commented Dec 31, 2015

👍 haven't run into this yet, but probably will soon.

@brianfaull
Copy link

I patched API Gateway functionality in commit
brianfaull@cd6173c
Narrowly targeted at API Gateway ("execute-api"), but it seems to work for me: calling Sign() or SignV4() works for API Gateway endpoints. I can PR if it's helpful, or it could be generalized for other 5-length services that are similar.
Thanks for this very helpful library.

@brianfaull
Copy link

Due to a failure on my part, I had to re-write history; identical diff-set now as
brianfaull@d18aee0
I apologize for any inconvenience.
Again, only works for generic (non-custom) API Gateway endpoints, like https://abcd1234yz.execute-api.us-east-1.amazonaws.com.

@rifflock
Copy link

rifflock commented Oct 8, 2016

I needed custom host name support so I opened a PR that supports it, @brianfaull I added in your change as well to support calls to non-custom hostnames.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants