{strip} doesn't remove white-spaces after comments {* *}

[duzun]

Here is an example:

{strip}
    <br />
    {* some comment *}
    <br />
{/strip}

->

<br />
    <br />

And there are some other edge cases around comments.

[peon501]

jeez all know this. Is this is problem to you :)

[wisskid]

This happens because smarty recognizes a newline directly following a comment as part of the comment and removes it. This is expected, since Smarty 2 would also do this. E.g.:

<tag1></tag1>
{* insightful comment *}
<tag2></tag2>

Is rendered as:

<tag1></tag1>
<tag2></tag2>

This, however causes the newline before the 4 spaces after the comment in de example above to have disappeared from the text content section. We can't take out any spaces at the beginning of a text content section, since that would remove inline spaces following a tag, e.g.:

{strip}{$amount}{if $showCurrency} EUR{if}{/strip}

would run together as

1337EUR

instead of the expected:

1337 EUR

Maybe we can merge consecutive text content sections before compiling them?

[duzun]

I understand this is an implementation detail.
But I see no semantic issue if strip would remove these spaces.
Merging consecutive text content sections before compiling them sounds reasonable.

In any case, this issue prevents me from commenting some parts of the templates. It is inconvenient.

[wisskid]

Could you test the branch in the linked Pull Request that I submitted yesterday? that should fix it.

[duzun]

Thank you @wisskid !
I've just updated smarty over composer and I see lots of spaces removed, just by upgrading!

If I find any issue or edge case, I'll let you know. It's been a while since I've posted this issue, thus I don't remember all the details.

This PR would definitely change the way we comment in smarty templates :)

[duzun]

ping @peon501

[duzun]

It looks great so far!
Can’t reproduce any of the issues related to comments any more.

[wisskid]

Thats good to hear. We noticed there are still issues with constructs such as; ``` {strip} {if $test} {* comment *} {$a = 3} {/if} {/strip} ```

[peon501]

@duzun ty for ping I will check it later :)