Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace -convey-json flag with env variable… #513

Open
powerman opened this issue Dec 24, 2017 · 0 comments
Open

Replace -convey-json flag with env variable… #513

powerman opened this issue Dec 24, 2017 · 0 comments

Comments

@powerman
Copy link

…and stop parsing source for goconveyDSLImport, please: https://github.com/smartystreets/goconvey/blob/master/web/server/system/shell.go#L171

It's very inconvenient requirement - add import _ "github.com/smartystreets/goconvey/convey" (for no reason) in each package which wanna get nice diff in goconvey's web UI for usual, non-Convey() tests (supposing this package implements goconvey-compatible JSON output).

Env var is much more simple and clean way to switch on feature which may not exists in executed binary, there is no reason to use flags for everything (especially at cost of needs to parse imports from source).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant