Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neither env var ever seems to be used for build? #11

Open
krainboltgreene opened this issue Apr 11, 2023 · 3 comments
Open

Neither env var ever seems to be used for build? #11

krainboltgreene opened this issue Apr 11, 2023 · 3 comments
Labels

Comments

@krainboltgreene
Copy link

I can't find any reference to either of the listed build configuration arguments.

@smashedtoatoms
Copy link
Owner

It appears I never got around to implementing that for this plugin. I built several of these plugins for a stack I was using at work over the course of a day many years ago and augmented them as required/requested over time. I've apparently never had anyone need to add options to this, which kinda blows my mind. What config options do you need to add? I can take some time next weekend or the weekend after and add that config. Having a use case definitely helps me verify that I have done it correctly.

@krainboltgreene
Copy link
Author

I have been there brother.

The TLS is really the only build option that I've ever needed.

@raxod502-plaid
Copy link

To be precise: BUILD_TLS=yes as per https://stackoverflow.com/a/73527252.

Also worth noting that you can work around this by setting BUILD_TLS=yes as an environment variable during the install, but it's rather confusing that just uninstalling and then reinstalling doesn't work, you have to manually add set -x to the plugin to find out what temporary directory it's using and then delete it to force a reconfigure, e.g. rm -rf /var/folders/bh/redacted/T/redis-7.0.10.

Also, I got this with Macports:

sentinel.c:34:10: fatal error: 'openssl/ssl.h' file not found
#include "openssl/ssl.h"
         ^~~~~~~~~~~~~~~

Needed to also export CFLAGS=-I/opt/local/libexec/openssl3/include for the install (and wipe the existing directory again to force a second reconfigure).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants