Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename deactivate_log() to something internally consistent #32

Open
beansrowning opened this issue Jan 16, 2018 · 0 comments
Open

Rename deactivate_log() to something internally consistent #32

beansrowning opened this issue Jan 16, 2018 · 0 comments

Comments

@beansrowning
Copy link

Maybe there is a greater reason for this that I am blind to, but I think it's a bit odd that all the other functions in the package are prefixed with log_, only to have the function to quit logging break this syntax.

Would log_close() or log_end() not work and be much more logical given the existing functions?
Just a thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant